Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12717 )
Change subject: add osmo_tdef API, moved from osmo-bsc T_def ...................................................................... Patch Set 3: Code-Review-1 (2 comments) If this is moved to a generic libosmocore sub-system, I'm starting to think how this would work in detail. It seems that there's no concept of a "timer group" or something that is a sub-node under the vty "tdef" node. The timer numbers in GSM are not globally unique, but they are locally scoped to each protocol or network element. Even more, we deal with other protocols like SCCP. So let's assume that both SCCP and BSSAP define a timer called "3", and both sub-sytems wanted to make use of this sub-system, how would this work? I'm sorry if I missed something. Putting a -1 as a precaution. I like the idea, let's just make sure if we move it to libosmocore we get it right the first time it is merged. https://gerrit.osmocom.org/#/c/12717/3/src/vty/tdef_vty.c File src/vty/tdef_vty.c: https://gerrit.osmocom.org/#/c/12717/3/src/vty/tdef_vty.c@119 PS3, Line 119: whitespace https://gerrit.osmocom.org/#/c/12717/3/tests/tdef/tdef_vty_test.vty File tests/tdef/tdef_vty_test.vty: https://gerrit.osmocom.org/#/c/12717/3/tests/tdef/tdef_vty_test.vty@4 PS3, Line 4: tdef I would appreciate a somewhat more human-readable name like "timer-definitons" instead of just "tdef". I believe we could use "timer-definitions" as the primary name and add "tdef" as an alias for compatibility, as desired/required? -- To view, visit https://gerrit.osmocom.org/12717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd6b1ed7f1bd6e1f2e0fde53352055a4468f23e5 Gerrit-Change-Number: 12717 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Comment-Date: Tue, 29 Jan 2019 10:41:47 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
