Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12717 )
Change subject: add osmo_tdef API, moved from osmo-bsc T_def ...................................................................... Patch Set 3: (1 comment) Though the node at which to locate T timer vty config is kept generic, there is no way to define more than one such set of timer definitions per main(). IIUC there might be a foo/T3 and a bar/T3 within the same program? In that case I need to use generic timer definitions handles instead of singleton globals. https://gerrit.osmocom.org/#/c/12717/3/tests/tdef/tdef_vty_test.vty File tests/tdef/tdef_vty_test.vty: https://gerrit.osmocom.org/#/c/12717/3/tests/tdef/tdef_vty_test.vty@4 PS3, Line 4: tdef > I would appreciate a somewhat more human-readable name like > "timer-definitons" instead of just "tdef […] 'tdef' is just a node created by tdef_vty_test.c, to clarify I'll make it "tdef-vty-test" -- To view, visit https://gerrit.osmocom.org/12717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd6b1ed7f1bd6e1f2e0fde53352055a4468f23e5 Gerrit-Change-Number: 12717 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Comment-Date: Wed, 30 Jan 2019 16:46:43 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
