Harald Welte has posted comments on this change. (
https://gerrit.osmocom.org/12717 )
Change subject: add osmo_tdef API, moved from osmo-bsc T_def
......................................................................
Patch Set 3:
> (1 comment)
>
> Though the node at which to locate T timer vty config is kept
> generic, there is no way to define more than one such set of timer
> definitions per main().
> IIUC there might be a foo/T3 and a bar/T3
> within the same program? In that case I need to use generic timer
> definitions handles instead of singleton globals.
there's two way to approach this:
1) have one "timer-definitons" root node and then per-subsystem nodes
underneath it, so
you have something like timer-definitions -> bsc
2) offer infrastructure to subsystems so that they can "instantiate" a timer
node underneath their VTY node
so you end up having something like network -> bcs -> bts ->
timer-definitions
Given that there are objects of which we have multiple instances (like multiple
BTSs in a BSC), it would actually make sense to go for approach number 2.
But yes, any of those will be moving away from the idea of having one global
namespace of timers.
--
To view, visit https://gerrit.osmocom.org/12717
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd6b1ed7f1bd6e1f2e0fde53352055a4468f23e5
Gerrit-Change-Number: 12717
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Comment-Date: Wed, 30 Jan 2019 17:05:52 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
