Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12874 )
Change subject: OML: Ensure minimum required attributes are set before accepting OPSTART ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12874/1/src/common/oml.c File src/common/oml.c: https://gerrit.osmocom.org/#/c/12874/1/src/common/oml.c@1009 PS1, Line 1009: return sizeof(bts_mand_attr); picky: due to being a list of uint8_t, sizeof() is same as num of elements, but it'd be more correct semantically to use OSMO_ARRAY_SIZE() or alike, specially if somebody decides later on to use another int data type for this list in the future. -- To view, visit https://gerrit.osmocom.org/12874 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a818f8eceb6abef1b20d2b3892a749dbc9e4b05 Gerrit-Change-Number: 12874 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Sun, 10 Feb 2019 17:10:49 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
