Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12874 )
Change subject: OML: Ensure minimum required attributes are set before accepting OPSTART ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12874/1/src/common/oml.c File src/common/oml.c: https://gerrit.osmocom.org/#/c/12874/1/src/common/oml.c@1009 PS1, Line 1009: return sizeof(bts_mand_attr); > picky: due to being a list of uint8_t, sizeof() is same as num of elements, > but it'd be more corre […] I agree in principle. However, in this specific case it's virtually impossible that somebody would ever change the type, given that the IEI (IE identifier) that we compare against is a uint8_t. I can change it, but I really think in this case it's not really worth it. -- To view, visit https://gerrit.osmocom.org/12874 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a818f8eceb6abef1b20d2b3892a749dbc9e4b05 Gerrit-Change-Number: 12874 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 11 Feb 2019 08:51:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
