dexter has posted comments on this change. ( https://gerrit.osmocom.org/12874 )
Change subject: OML: Ensure minimum required attributes are set before accepting OPSTART ...................................................................... Patch Set 1: Verified-1 I have checked the patch set. All patches except this one seem to be fine. However, this patch now blocks the oml startup because osmo-bsc sends an opstart to the radio-carrier early. The reason for this is presumably that the radio-carrier is initalized in unlocked state. Also I can see that Get Attribute requests now fail and osmo-bts emits malformed Get Attribute NACK messages -- To view, visit https://gerrit.osmocom.org/12874 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a818f8eceb6abef1b20d2b3892a749dbc9e4b05 Gerrit-Change-Number: 12874 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-Comment-Date: Mon, 11 Feb 2019 16:04:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
