Max has posted comments on this change. ( https://gerrit.osmocom.org/12990 )
Change subject: trxcon/scheduler: count number of measurements ...................................................................... Patch Set 1: (1 comment) Would be nice to get more detailed explanation in commit message as to why this is the right thing. Was dbm_avg too high/incorrect before? https://gerrit.osmocom.org/#/c/12990/1/src/host/trxcon/sched_lchan_common.c File src/host/trxcon/sched_lchan_common.c: https://gerrit.osmocom.org/#/c/12990/1/src/host/trxcon/sched_lchan_common.c@104 PS1, Line 104: dbm_avg = lchan->meas.rssi_sum / lchan->meas.num; So now you will end up with lower dbm_avg value than before because meas.num = meas.rssi_num + meas.toa256_num? -- To view, visit https://gerrit.osmocom.org/12990 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45454a3ac92b8cc85dd74092e4ab6eb350f20c9a Gerrit-Change-Number: 12990 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-CC: Max <[email protected]> Gerrit-Comment-Date: Thu, 21 Feb 2019 12:32:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
