Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12990 )
Change subject: trxcon/scheduler: count number of measurements ...................................................................... Patch Set 1: (1 comment) Hi Max, > Would be nice to get more detailed explanation in commit message > as to why this is the right thing. I believe the commit message is satisfactory, please read it carefully. In other words: We used to count the amount of both RSSI and ToA measurements separately, but since we always receive both, i.e. there are no cases when we receive either RSSI, or ToA, it makes sense to have a shared counter of measurements. > Was dbm_avg too high/incorrect before? No. It would be calculated in the same way as before. > Patch Set 1: Code-Review-1 > Also, why +2 with no reviews? Because at the moment we have a lack of code review. Some of my further changes depend on this one, so I need to get it merged ASAP. Also, I have not merged this change immediately, so I don't see any problems here. https://gerrit.osmocom.org/#/c/12990/1/src/host/trxcon/sched_lchan_common.c File src/host/trxcon/sched_lchan_common.c: https://gerrit.osmocom.org/#/c/12990/1/src/host/trxcon/sched_lchan_common.c@104 PS1, Line 104: dbm_avg = lchan->meas.rssi_sum / lchan->meas.num; > because meas.num = meas.rssi_num + meas.toa256_num? >From where this assumption comes from? > now you will end up with lower dbm_avg value than before No. -- To view, visit https://gerrit.osmocom.org/12990 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45454a3ac92b8cc85dd74092e4ab6eb350f20c9a Gerrit-Change-Number: 12990 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Thu, 21 Feb 2019 13:49:29 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
