Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/13123 )

Change subject: add osmo_ip_port API
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/#/c/13123/4/include/osmocom/core/ip_port.h
File include/osmocom/core/ip_port.h:

https://gerrit.osmocom.org/#/c/13123/4/include/osmocom/core/ip_port.h@51
PS4, Line 51: 46
> I had used that at first, but it causes a dependency on #include <netinet/in. 
> […]
actually no, on my machine I find INET6_ADDRSTRLEN in netinet/in.h, so exactly 
the problem I have should remain on ARM. But let's ask jenkins to give it a 
try...



--
To view, visit https://gerrit.osmocom.org/13123
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id617265337f09dfb6ddfe111ef5e578cd3dc9f63
Gerrit-Change-Number: 13123
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-CC: Harald Welte <[email protected]>
Gerrit-Comment-Date: Wed, 06 Mar 2019 00:37:01 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to