Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13123 )
Change subject: add osmo_ip_port API ...................................................................... Patch Set 5: But! Looking at the results from the two patch sets of https://gerrit.osmocom.org/13140 I notice that arpa/inet.h is also not available on ARM. The only reason building succeeds is because the ip_port.h is never built. The #if in ip_port.c even prevents including the header, and hence we end up installing a header file on ARM that is not usable there. I'll try completely omitting ip_port.[hc] on ARM instead. -- To view, visit https://gerrit.osmocom.org/13123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id617265337f09dfb6ddfe111ef5e578cd3dc9f63 Gerrit-Change-Number: 13123 Gerrit-PatchSet: 5 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Wed, 06 Mar 2019 01:20:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
