Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13123 )
Change subject: add osmo_ip_port API ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/13123/4/include/osmocom/core/ip_port.h File include/osmocom/core/ip_port.h: https://gerrit.osmocom.org/#/c/13123/4/include/osmocom/core/ip_port.h@47 PS4, Line 47: osmo_ip_port > I understand the attractive / leaner approach of using operating system > structs. […] ok, let's rename to osmo_sockaddr_str and let's merge it to libosmocore. -- To view, visit https://gerrit.osmocom.org/13123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id617265337f09dfb6ddfe111ef5e578cd3dc9f63 Gerrit-Change-Number: 13123 Gerrit-PatchSet: 4 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Mon, 11 Mar 2019 13:29:05 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
