Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13067 )
Change subject: MCS: move HeaderType enum outside of class definition ...................................................................... Patch Set 5: (4 comments) https://gerrit.osmocom.org/#/c/13067/5/debian/copyright File debian/copyright: https://gerrit.osmocom.org/#/c/13067/5/debian/copyright@9 PS5, Line 9: 2016-2017 sysmocom s.m.f.c. GmbH <[email protected]> Update copyright year https://gerrit.osmocom.org/#/c/13067/5/src/coding_scheme.h File src/coding_scheme.h: https://gerrit.osmocom.org/#/c/13067/5/src/coding_scheme.h@43 PS5, Line 43: uint8_t numDataBlocks(enum HeaderType ht); What about using usual C style code in new functions we add? num_data_blocks() This way when looking at it being called it's easier to understand it's an external function and not a function of the class instance (since you can ommit "this->"). https://gerrit.osmocom.org/#/c/13067/5/src/gprs_coding_scheme.h File src/gprs_coding_scheme.h: https://gerrit.osmocom.org/#/c/13067/5/src/gprs_coding_scheme.h@a70 PS5, Line 70: This one looks non-related, I didn't see it being moved somewhere else like other stuff. https://gerrit.osmocom.org/#/c/13067/5/src/gprs_coding_scheme.cpp File src/gprs_coding_scheme.cpp: https://gerrit.osmocom.org/#/c/13067/5/src/gprs_coding_scheme.cpp@a320 PS5, Line 320: Same. If it's really not used, drop it in another commit. -- To view, visit https://gerrit.osmocom.org/13067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0873f85e1f16a72e17e7fbc4ad76b194917067f Gerrit-Change-Number: 13067 Gerrit-PatchSet: 5 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Wed, 13 Mar 2019 11:37:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
