Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13067 )
Change subject: MCS: move HeaderType enum outside of class definition ...................................................................... Patch Set 7: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/13067/7/src/coding_scheme.c File src/coding_scheme.c: https://gerrit.osmocom.org/#/c/13067/7/src/coding_scheme.c@43 PS7, Line 43: uint8_t num_data_blocks(enum HeaderType ht) : { : return hdr_type_info[ht].num_blocks; : } : : uint8_t num_data_header_bits_UL(enum HeaderType ht) : { : return hdr_type_info[ht].uplink.data_header_bits; : } : : uint8_t num_data_header_bits_DL(enum HeaderType ht) : { : return hdr_type_info[ht].downlink.data_header_bits; : } : : uint8_t num_data_block_header_bits(enum HeaderType ht) : { : return hdr_type_info[ht].data_block_header_bits; : } none of those functions protect against array out-of-index access. -- To view, visit https://gerrit.osmocom.org/13067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0873f85e1f16a72e17e7fbc4ad76b194917067f Gerrit-Change-Number: 13067 Gerrit-PatchSet: 7 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Tue, 19 Mar 2019 13:20:28 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
