Max has posted comments on this change. ( https://gerrit.osmocom.org/13067 )
Change subject: MCS: move HeaderType enum outside of class definition ...................................................................... Patch Set 7: (1 comment) https://gerrit.osmocom.org/#/c/13067/7/src/coding_scheme.h File src/coding_scheme.h: https://gerrit.osmocom.org/#/c/13067/7/src/coding_scheme.h@44 PS7, Line 44: uint8_t num_data_header_bits_UL(enum HeaderType ht); > those UL/DL in caps hurt my eyes That's the whole point :) I mean - the lesser the chance for typos, the better. -- To view, visit https://gerrit.osmocom.org/13067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0873f85e1f16a72e17e7fbc4ad76b194917067f Gerrit-Change-Number: 13067 Gerrit-PatchSet: 7 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Wed, 13 Mar 2019 19:16:22 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
