Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13242 )
Change subject: libmsc: Allow different channel types to be requested as silent calls ...................................................................... Patch Set 1: (6 comments) https://gerrit.osmocom.org/#/c/13242/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/13242/1//COMMIT_MSG@10 PS1, Line 10: Signed-off-by: Sylvain Munaut <[email protected]> No signed-off-by in osmocom repos. https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/msc_vty.c@1072 PS1, Line 1072: uint16_t port = 0; no initialization needed here afaiu. https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c File src/libmsc/silent_call.c: https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@40 PS1, Line 40: char traffic_ip[INET_ADDRSTRLEN]; worth using INET6_ADDRSTRLEN here in case we want to support ipv6? Not sure if it makes sense in this context. https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@91 PS1, Line 91: osmo_timer_schedule(&scd->timer, 0, 0); Why not calling timer_cb directly around line 120? You are immediatelly firing this cb, and only once. https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@99 PS1, Line 99: } rtp_addr; Is this conversion from sockaddr_in to sockaddr_storage through union valid? Never seen it before. https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@120 PS1, Line 120: break; Would be clearer using a return 0 here, otherwise it's confusing scheduling scd timer then having a talloc_free(scd) after the switch block. -- To view, visit https://gerrit.osmocom.org/13242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82645708dd27864cf33ea9cc993ead0983415602 Gerrit-Change-Number: 13242 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Max <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Wed, 13 Mar 2019 19:21:01 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
