Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13242 )
Change subject: libmsc: Allow different channel types to be requested as silent calls ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/msc_vty.c@1063 PS1, Line 1063: 65536 I may be wrong, but shouldn't it be 65535? 0xffff is 65535 + 0, so 65536 possible values in total. -- To view, visit https://gerrit.osmocom.org/13242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82645708dd27864cf33ea9cc993ead0983415602 Gerrit-Change-Number: 13242 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: tnt <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-CC: Max <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Thu, 14 Mar 2019 07:55:51 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
