tnt has posted comments on this change. ( https://gerrit.osmocom.org/13242 )
Change subject: libmsc: Allow different channel types to be requested as silent calls ...................................................................... Patch Set 3: (2 comments) Fixed in latest patch set. https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c File src/libmsc/silent_call.c: https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@196 PS1, Line 196: > Rather sizeof(*ct), so it would be safe to rename 'gsm0808_channel_type' > symbol later on... […] Ack https://gerrit.osmocom.org/#/c/13242/1/src/libmsc/silent_call.c@199 PS1, Line 199: > Are you sure it would calculate the size of the string buffer and not the > size of pointer? (Personal […] I am sure. -- To view, visit https://gerrit.osmocom.org/13242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82645708dd27864cf33ea9cc993ead0983415602 Gerrit-Change-Number: 13242 Gerrit-PatchSet: 3 Gerrit-Owner: tnt <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: tnt <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Thu, 14 Mar 2019 10:05:55 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
