Max has posted comments on this change. ( https://gerrit.osmocom.org/13253 )
Change subject: Use dumpcap for ttcn3-tcpdump-*.sh if available ...................................................................... Patch Set 3: > I really like the idea and I'm surprised we didn't do this sooner. However, > the fact that dumpcap is installed doesn't mean that a) it's setuid-root, or > b) the current user has the right group/permission You're right. Moreover, on some system it might not have setuid-root but still allow users to capture traffic due to capabilities set: getcap /usr/bin/dumpcap /usr/bin/dumpcap = cap_net_admin,cap_net_raw+eip so we can't just check for the bit either. I'll check how we can make this check more robust. -- To view, visit https://gerrit.osmocom.org/13253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77df04d51a469c924cf727f0596cc33565909746 Gerrit-Change-Number: 13253 Gerrit-PatchSet: 3 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Daniel Willmann <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Fri, 15 Mar 2019 11:58:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
