Max has posted comments on this change. ( https://gerrit.osmocom.org/13253 )
Change subject: Use dumpcap for ttcn3-tcpdump-*.sh if available ...................................................................... Patch Set 5: (4 comments) The tcpdump might be installed into non-standard location as well but we don't take that into account. How common is to have tcpdump and dumpcap in different directories? https://gerrit.osmocom.org/#/c/13253/4/ttcn3-tcpdump-start.sh File ttcn3-tcpdump-start.sh: https://gerrit.osmocom.org/#/c/13253/4/ttcn3-tcpdump-start.sh@5 PS4, Line 5: DUMPCAP=/usr/bin/dumpcap > Mine is in /usr/local/bin/dumpcap. […] Yes, we have to use absolute path because of setcap. I'm somewhat reluctant to make it more complex by checking for unusual path - after all the goal is to make it work with the most common setup, not to support every distro imaginable. https://gerrit.osmocom.org/#/c/13253/4/ttcn3-tcpdump-start.sh@30 PS4, Line 30: /sbin/setcap > (might not be installed on all distributions there, I would have checked with > "command") Well if it's not installed than this check would simply fail and we're back to tcpdump. https://gerrit.osmocom.org/#/c/13253/4/ttcn3-tcpdump-start.sh@37 PS4, Line 37: el > How about telling the user why dumpcap is not used? […] Done https://gerrit.osmocom.org/#/c/13253/4/ttcn3-tcpdump-stop.sh File ttcn3-tcpdump-stop.sh: https://gerrit.osmocom.org/#/c/13253/4/ttcn3-tcpdump-stop.sh@35 PS4, Line 35: DUMPER="$(ps -q "$(cat "$PIDFILE")" -o comm=)" > Consider replacing `` with $(). […] Done -- To view, visit https://gerrit.osmocom.org/13253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77df04d51a469c924cf727f0596cc33565909746 Gerrit-Change-Number: 13253 Gerrit-PatchSet: 5 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Daniel Willmann <dwillm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: tnt <t...@246tnt.com> Gerrit-Comment-Date: Mon, 18 Mar 2019 15:16:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
