osmith has posted comments on this change. ( https://gerrit.osmocom.org/13253 )

Change subject: Use dumpcap for ttcn3-tcpdump-*.sh if available
......................................................................


Patch Set 5: Code-Review+1

>  I'm somewhat reluctant to make it more complex by checking for unusual path 
> - after all the goal is to make it work with the most common setup, not to 
> support every distro imaginable.

Fair enough.

> How common is to have tcpdump and dumpcap in different directories?

Building wireshark from git and using "make install" with defaults, as 
described here: 
https://osmocom.org/projects/cellular-infrastructure/wiki/Wireshark#Building-and-installing

But I just realized: `apt install wireshark` and I have another copy of dumpcap 
in the supported dir :)


--
To view, visit https://gerrit.osmocom.org/13253
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77df04d51a469c924cf727f0596cc33565909746
Gerrit-Change-Number: 13253
Gerrit-PatchSet: 5
Gerrit-Owner: Max <msur...@sysmocom.de>
Gerrit-Reviewer: Daniel Willmann <dwillm...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msur...@sysmocom.de>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: tnt <t...@246tnt.com>
Gerrit-Comment-Date: Mon, 18 Mar 2019 15:28:35 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Reply via email to