Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13713 )
Change subject: Create subscribers on demand ...................................................................... Patch Set 2: Code-Review-1 (2 comments) I think both network access mode (PS or CS) and random MSISDN assignment should be separate independent parameters. For example, one may not want to assign MSISDNs, but still allow PS, CS, or both... At least for PS, having a valid MSISDN is not mandatory I think. https://gerrit.osmocom.org/#/c/13713/2/src/hlr.h File src/hlr.h: https://gerrit.osmocom.org/#/c/13713/2/src/hlr.h@63 PS2, Line 63: int unsigned https://gerrit.osmocom.org/#/c/13713/2/src/hlr_vty.c File src/hlr_vty.c: https://gerrit.osmocom.org/#/c/13713/2/src/hlr_vty.c@365 PS2, Line 365: NAM (Numeric Assignment Module) I thought it's "Network Access Mode" :D -- To view, visit https://gerrit.osmocom.org/13713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c9fe93f5c24b5e9fefb513c4d049fb7ebd47ecd Gerrit-Change-Number: 13713 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Wed, 08 May 2019 13:43:06 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
