osmith has posted comments on this change. ( https://gerrit.osmocom.org/13713 )
Change subject: Create subscribers on demand ...................................................................... Patch Set 3: (4 comments) https://gerrit.osmocom.org/#/c/13713/3/src/hlr.h File src/hlr.h: https://gerrit.osmocom.org/#/c/13713/3/src/hlr.h@63 PS3, Line 63: uint8_t > Unsigned int. No need to use fixed-size type here. Done https://gerrit.osmocom.org/#/c/13713/3/src/hlr.c File src/hlr.c: https://gerrit.osmocom.org/#/c/13713/3/src/hlr.c@158 PS3, Line 158: int > Unsigned int. Done https://gerrit.osmocom.org/#/c/13713/3/src/hlr.c@173 PS3, Line 173: rand_msisdn_len > Feel free to inverse this statement, so this would allow to reduce code > nesting: […] Good idea, done. https://gerrit.osmocom.org/#/c/13713/3/src/hlr_vty.c File src/hlr_vty.c: https://gerrit.osmocom.org/#/c/13713/3/src/hlr_vty.c@358 PS3, Line 358: 3 > AFAIR, a single digit is also a valid MSISDN ;) Yes, but then the HLR would run out of available msisdns very fast, so I don't think there's practical value in allowing less than three digits. Unless you want to set up a 'first 10 people who join the network can use it for free' type of thing ;D So I would keep the 3 there, to make it harder to misconfigure the feature, and change it only if somebody has a real world use case. -- To view, visit https://gerrit.osmocom.org/13713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c9fe93f5c24b5e9fefb513c4d049fb7ebd47ecd Gerrit-Change-Number: 13713 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Fri, 10 May 2019 12:18:55 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
