osmith has posted comments on this change. ( https://gerrit.osmocom.org/13713 )
Change subject: Create subscribers on demand ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/13713/5/src/hlr.c File src/hlr.c: https://gerrit.osmocom.org/#/c/13713/5/src/hlr.c@176 PS5, Line 176: while (1) { > This generates an infinite loop if all the msisdns are used up, I'm not so > happy with that. […] Done. I've also moved the msisdn generation before subscriber creation. That makes it possible for users to retry (e.g. turning phone off and on again) if they had bad luck and the random MSISDNs generated were all pointing to existing entries. -- To view, visit https://gerrit.osmocom.org/13713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c9fe93f5c24b5e9fefb513c4d049fb7ebd47ecd Gerrit-Change-Number: 13713 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Mon, 13 May 2019 07:53:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
