Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13713 )
Change subject: Create subscribers on demand ...................................................................... Patch Set 7: Code-Review-1 (3 comments) let's use this chance to get rid of old mistakes in terms of naming https://gerrit.osmocom.org/#/c/13713/7//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/13713/7//COMMIT_MSG@12 PS7, Line 12: -extension we don't call it an 'extension' anymore in the post-NITB world. Let's call it MSISDN, i.e. what it truly is. https://gerrit.osmocom.org/#/c/13713/7/src/hlr_vty.c File src/hlr_vty.c: https://gerrit.osmocom.org/#/c/13713/7/src/hlr_vty.c@358 PS7, Line 358: extension msisdn https://gerrit.osmocom.org/#/c/13713/7/src/hlr_vty.c@360 PS7, Line 360: extension MSISDN -- To view, visit https://gerrit.osmocom.org/13713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c9fe93f5c24b5e9fefb513c4d049fb7ebd47ecd Gerrit-Change-Number: 13713 Gerrit-PatchSet: 7 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Sun, 19 May 2019 07:22:29 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
