pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14591 )
Change subject: osmo-bts-trx/trx_if.c: use osmo_loadXXbe() for TDMA FN and ToA256 ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/14591/1/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/#/c/14591/1/src/osmo-bts-trx/trx_if.c@43 PS1, Line 43: #include <osmocom/core/bit32gen.h> I think you should include #include <osmocom/core/bits.h> instead. https://gerrit.osmocom.org/#/c/14591/1/src/osmo-bts-trx/trx_if.c@617 PS1, Line 617: fn = osmo_load32be(buf + 1); Can we use array offsets instead of mixing them with pointer arithmetic? fn = osmo_load32be(&buf[1]); https://gerrit.osmocom.org/#/c/14591/1/src/osmo-bts-trx/trx_if.c@619 PS1, Line 619: toa256 = (int16_t) osmo_load16be(buf + 6); toa256 = (int16_t) osmo_load16be(&buf[6]); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iec0d86f9be7243578ddc1ab322fc313cb5ac5d0b Gerrit-Change-Number: 14591 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Wed, 26 Jun 2019 08:33:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
