pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14591 )
Change subject: osmo-bts-trx/trx_if.c: use osmo_loadXXbe() for TDMA FN and ToA256 ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14591/1/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/#/c/14591/1/src/osmo-bts-trx/trx_if.c@617 PS1, Line 617: fn = osmo_load32be(buf + 1); > Heh, I expected your comment as you're always against using pointer > arithmetic ;) […] You missed the important part: "instead of mixing them". So imho either use array indices everywhere or pointer arithmetic everywhere, but don't go using one and then on next line using another, that makes code harder to read/understand. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iec0d86f9be7243578ddc1ab322fc313cb5ac5d0b Gerrit-Change-Number: 14591 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Wed, 26 Jun 2019 10:00:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
