laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14877 )
Change subject: scheduler_trx: Handle negative return of gsm0503_tch_hr_decode() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14877/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/14877/1/src/osmo-bts-trx/scheduler_trx.c@1331 PS1, Line 1331: rc > Does it make sense to pass 0 here? yes, I think it still makes sense to set the marker for a non-SID frame, as hr_check_sid() would determine that a zero-length frame cannot be a SID frame. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14877 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If49ca6926c576a2b17507b6a95b6f3ca17877d66 Gerrit-Change-Number: 14877 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Comment-Date: Sun, 21 Jul 2019 11:03:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
