keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997 )
Change subject: Add further logging. ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14997/1/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/14997/1/src/mncc.c@191 PS1, Line 191: struct in_addr net = { .s_addr = other->ip }; > Well, according to existing code [mncc. […] just making notes... in sdp_extract_sdp, the code is: struct in_addr addr; inet_aton(conn->c_address, &addr); leg->base.ip = addr.s_addr; so the values stored in (struct call)->ip are always network byte order. but then, the original code was: mncc.ip = htonl(other->ip); so this is wrong, no? -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I2620cce245be199d849d8fad3fc998c96c243f6b Gerrit-Change-Number: 14997 Gerrit-PatchSet: 1 Gerrit-Owner: keith <ke...@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <ke...@rhizomatica.org> Gerrit-Reviewer: laforge <lafo...@gnumonks.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 06 Aug 2019 11:55:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: keith <ke...@rhizomatica.org> Gerrit-MessageType: comment
