pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997 )
Change subject: Add further logging. ...................................................................... Patch Set 7: (1 comment) https://gerrit.osmocom.org/#/c/14997/1/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/14997/1/src/mncc.c@191 PS1, Line 191: struct in_addr net = { .s_addr = other->ip }; > just making notes... […] So the result is probably fine because htonl() and ntohl() are implemented the same way afaik, but from what you say, it should be ntohl() then since apparently other->ip is network byte order, and what we send over the unix MNCC socket appears to be host byte order. You can make sure also by checking implementation of the peer on the other side of the unix mncc socket. -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I2620cce245be199d849d8fad3fc998c96c243f6b Gerrit-Change-Number: 14997 Gerrit-PatchSet: 7 Gerrit-Owner: keith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Tue, 06 Aug 2019 12:00:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: keith <[email protected]> Gerrit-MessageType: comment
