neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15242 )
Change subject: fix crashes: don't assert on incoming RTP packet size ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/15242/2/src/libosmo-mgcp/mgcp_network.c File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/#/c/15242/2/src/libosmo-mgcp/mgcp_network.c@752 PS2, Line 752: static int amr_oa_check(char *data, int len) > non-related. […] if you return true or false, it always says whether octet-aligned is on or off. I need a third value saying that the RTP header was invalid, so ... should add an api doc https://gerrit.osmocom.org/#/c/15242/2/src/libosmo-mgcp/mgcp_network.c@1363 PS2, Line 1363: if (((bool)oa) != conn_src->end.codec->param.amr_octet_aligned) > non-related change. it is related: instead of asserting on invalid header size, I need to handle that error by returning -1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6bc6ee950ce07bcc2c585c30fad02b81153bdde2 Gerrit-Change-Number: 15242 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 21 Aug 2019 20:49:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
