Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-mgw/+/15242 to look at the new patch set (#3). Change subject: fix crashes: don't assert on incoming RTP packet size ...................................................................... fix crashes: don't assert on incoming RTP packet size Remove various OSMO_ASSERT() on size of incoming packets. Doing an assert on incoming data is a DoS attack vector, absolute no-go. Instead, return -EINVAL and keep running. Change some return values to be able to distinguish successful operation from invalid RTP sizes. In rtp_data_net(), make sure to return negative if the RTP packet was invalid. Some of the error return codes implemented here will only be used in upcoming patch Iba115a0b1d74e7cefba5dcdd777e98ddea9eba8c. Change-Id: I6bc6ee950ce07bcc2c585c30fad02b81153bdde2 --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 32 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/42/15242/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6bc6ee950ce07bcc2c585c30fad02b81153bdde2 Gerrit-Change-Number: 15242 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-MessageType: newpatchset