pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15242 )
Change subject: fix crashes: don't assert on incoming RTP packet size ...................................................................... Patch Set 3: (1 comment) I think you have lots of duplicates for same check (len < sizeof(struct rtp_hdr)) all around, some them being hit by same packet. That's because these checks are at the end of code paths, while they should be in previous more generic paths (like when receiving an rtp packet), and have it only there. Specially since most functions containing the checks are static which means are called by same parent functions... https://gerrit.osmocom.org/#/c/15242/3/src/libosmo-mgcp/mgcp_network.c File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/#/c/15242/3/src/libosmo-mgcp/mgcp_network.c@511 PS3, Line 511: return; This one shoudl return -EINVAL too. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6bc6ee950ce07bcc2c585c30fad02b81153bdde2 Gerrit-Change-Number: 15242 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 22 Aug 2019 10:35:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
