fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15613 )
Change subject: struct gsm_bts: Add model_priv pointer handing bts_model specific data ...................................................................... Patch Set 3: (4 comments) Agree with Harald: what do we benefit from this change? The current approach with union looks good to me, what's wrong with it? https://gerrit.osmocom.org/#/c/15613/3/src/osmo-bts-oc2g/l1_if.h File src/osmo-bts-oc2g/l1_if.h: https://gerrit.osmocom.org/#/c/15613/3/src/osmo-bts-oc2g/l1_if.h@37 PS3, Line 37: Could you please use tabs for alignment? I know, you're just moving this definition 'as-is', but other blocks in this file already using tabs, so this one would also be consistent. https://gerrit.osmocom.org/#/c/15613/3/src/osmo-bts-virtual/l1_if.h File src/osmo-bts-virtual/l1_if.h: https://gerrit.osmocom.org/#/c/15613/3/src/osmo-bts-virtual/l1_if.h@8 PS3, Line 8: specific to osmo-bts-virtual Actually, no. It's specific to both osmo-bts-trx and osmo-bts-virtual as the last one reuses some parts of the TDMA scheduler. https://gerrit.osmocom.org/#/c/15613/3/src/osmo-bts-virtual/main.c File src/osmo-bts-virtual/main.c: https://gerrit.osmocom.org/#/c/15613/3/src/osmo-bts-virtual/main.c@60 PS3, Line 60: zero I would avoid using zero-initialization here. This structure is getting initialized in vbts_sched_start() anyway, and moreover it makes harder to catch uninitialized memory access. https://gerrit.osmocom.org/#/c/15613/3/src/osmo-bts-virtual/scheduler_virtbts.c File src/osmo-bts-virtual/scheduler_virtbts.c: https://gerrit.osmocom.org/#/c/15613/3/src/osmo-bts-virtual/scheduler_virtbts.c@604 PS3, Line 604: Alignment. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib17a752cdbaa7d5eb8c5dfa0b197f80a4f38b38e Gerrit-Change-Number: 15613 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Sat, 28 Sep 2019 16:39:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
