fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15613 )
Change subject: struct gsm_bts: Add model_priv pointer handing bts_model specific data ...................................................................... Patch Set 4: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/15613/4/include/osmo-bts/gsm_data_shared.h File include/osmo-bts/gsm_data_shared.h: https://gerrit.osmocom.org/#/c/15613/4/include/osmo-bts/gsm_data_shared.h@778 PS4, Line 778: model_priv Ok, I just realized a meaningful advantage of your approach over having a union with model-specific structures: those structures may contain really specific data, e.g. structures or other types from their header files (SDKs). We don't want to pollute this header file with such stuff. https://gerrit.osmocom.org/#/c/15613/4/src/osmo-bts-virtual/l1_if.h File src/osmo-bts-virtual/l1_if.h: https://gerrit.osmocom.org/#/c/15613/4/src/osmo-bts-virtual/l1_if.h@9 PS4, Line 9: bts_virt_priv LOL, I was pretty sure osmo-bts-trx is also using this structure. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib17a752cdbaa7d5eb8c5dfa0b197f80a4f38b38e Gerrit-Change-Number: 15613 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Sat, 05 Oct 2019 11:16:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
