pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15613 )
Change subject: struct gsm_bts: Add model_priv pointer handing bts_model specific data ...................................................................... Patch Set 3: WHY: because I have to add new per-bts data which is specific to bts-trx WHY2: because currently we already have bts-trx specific data in there which is not used by other models as shown by this patch. An alternative would be having a union with different structs for each model, but since we already have the bts_model abstraction, in this case it makes more sense to use that abstraction instead of filling code with preprocessor ifdefs to guard against not-defined types, etc. So unless you strongly prefer the alternative, I'll keep it this way. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib17a752cdbaa7d5eb8c5dfa0b197f80a4f38b38e Gerrit-Change-Number: 15613 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Mon, 30 Sep 2019 09:51:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
