lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15547 )
Change subject: sgsn_libgtp: refactor ps cell paging into gprs_gb ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/15547/2/src/sgsn/gprs_gb.c File src/sgsn/gprs_gb.c: https://gerrit.osmocom.org/#/c/15547/2/src/sgsn/gprs_gb.c@90 PS2, Line 90: /* FIXME: page whole routing area, not only the last known cell */ > This FIXME doesn't belong here right? because the function is called > "gprs_gb_page_ps_cell". good point. I don't know if SUSPENDed MS can move within the routing area, but I would expect this. https://gerrit.osmocom.org/#/c/15547/1/src/sgsn/sgsn_libgtp.c File src/sgsn/sgsn_libgtp.c: https://gerrit.osmocom.org/#/c/15547/1/src/sgsn/sgsn_libgtp.c@663 PS1, Line 663: gprs_gb_page_ps_cell(mm); > Good idea! That's a new patch :) Do you want to create a ticket for it? Actual no, it's not needed to check here for different RAN, as Iu is filtered out earlier. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15547 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3020020f52005aa460ca6b245ee2297aec9821b3 Gerrit-Change-Number: 15547 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2019 15:59:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lyn...@fe80.eu> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
