laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15547 )
Change subject: sgsn_libgtp: refactor ps paging into gprs_gb ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15547/2/src/sgsn/gprs_gb.c File src/sgsn/gprs_gb.c: https://gerrit.osmocom.org/#/c/15547/2/src/sgsn/gprs_gb.c@90 PS2, Line 90: /* FIXME: page whole routing area, not only the last known cell */ > I'm not sure if paging should be done at all for MS in SUSPEND. […] I also would assume that packet paging while in SUSPEND is actually a contradiction in itself. IF the MS sends us a GMM SUSPEND, then it's to tell us that it's entering dedicated mode on circuit-switched services (and is not DTM capable), and hence not reachable for GPRS. But this can be adressed in a separate follow-up patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15547 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3020020f52005aa460ca6b245ee2297aec9821b3 Gerrit-Change-Number: 15547 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Tue, 08 Oct 2019 20:37:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lyn...@fe80.eu> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
