lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15547 )
Change subject: sgsn_libgtp: refactor ps paging into gprs_gb ...................................................................... Patch Set 3: (3 comments) https://gerrit.osmocom.org/#/c/15547/3/include/osmocom/sgsn/gprs_gb.h File include/osmocom/sgsn/gprs_gb.h: https://gerrit.osmocom.org/#/c/15547/3/include/osmocom/sgsn/gprs_gb.h@13 PS3, Line 13: /* page a MS in it routing area */ > its Done https://gerrit.osmocom.org/#/c/15547/2/include/osmocom/sgsn/gprs_gb.h File include/osmocom/sgsn/gprs_gb.h: https://gerrit.osmocom.org/#/c/15547/2/include/osmocom/sgsn/gprs_gb.h@13 PS2, Line 13: /* page a MS in it's specific cell */ > its Done https://gerrit.osmocom.org/#/c/15547/2/src/sgsn/gprs_gb.c File src/sgsn/gprs_gb.c: https://gerrit.osmocom.org/#/c/15547/2/src/sgsn/gprs_gb.c@90 PS2, Line 90: /* FIXME: page whole routing area, not only the last known cell */ > good point. I don't know if SUSPENDed MS can move within the routing area, > but I would expect this. I'm not sure if paging should be done at all for MS in SUSPEND. I've changed function name and commit message. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15547 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3020020f52005aa460ca6b245ee2297aec9821b3 Gerrit-Change-Number: 15547 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2019 16:54:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lyn...@fe80.eu> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
