dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15888 )
Change subject: l1sap: add measurement related struct members ...................................................................... Patch Set 5: (5 comments) https://gerrit.osmocom.org/c/libosmocore/+/15888/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/15888/2//COMMIT_MSG@7 PS2, Line 7: l1sap: add measurement related struct memebers > members Done https://gerrit.osmocom.org/c/libosmocore/+/15888/2//COMMIT_MSG@9 PS2, Line 9: disolve > disSolve Done https://gerrit.osmocom.org/c/libosmocore/+/15888/3/include/osmocom/gsm/l1sap.h File include/osmocom/gsm/l1sap.h: https://gerrit.osmocom.org/c/libosmocore/+/15888/3/include/osmocom/gsm/l1sap.h@99 PS3, Line 99: int16_t ta_offs_qbits; /*!< timing advance offset (in qbits) */ : int16_t ta_offs_256bits;/*!< timing advance offset (in 1/256th bits) */ > why a union why not always stort 256ths? If somebody has or wants a > quarter-bit, they cna do the bi […] To me this union does not make sense, its two times the same type, so regardless which of thetwo I access, I will get the same result. Do I miss some magic here? https://gerrit.osmocom.org/c/libosmocore/+/15888/2/include/osmocom/gsm/l1sap.h File include/osmocom/gsm/l1sap.h: https://gerrit.osmocom.org/c/libosmocore/+/15888/2/include/osmocom/gsm/l1sap.h@87 PS2, Line 87: flags > What is the purpose of these flags? And why only one bit? As far as I know this has something to do with DTX, the purpose is to mark the frame as sub-frame. osmo-bts-trx seems not to make use of this flag, but maybe the phy-based BTSs do. In l1sap.c this value is indeed picked up and transfered to struct bts_ul_meas, so it is needed indeed needed for the calculation. https://gerrit.osmocom.org/c/libosmocore/+/15888/2/include/osmocom/gsm/l1sap.h@99 PS2, Line 99: ta_offs_qbits > Do we really need this field in the new API? Basically, QTA == (ToA256 >> 6). The measurement processing makes use of this field, so its needed. However I do not fully understand why it is this union. (maybe this API needs a bit of renovation. I also do not get why it is defined in libosmocore, its only used by osmo-bts?) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15888 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2c34b02d329f9df190c5035c396403ca0a4f9c42 Gerrit-Change-Number: 15888 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Mon, 11 Nov 2019 13:06:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
