Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370 )
Change subject: pcu: Refactor GPRS infrastructure to keep state and simplify tests ...................................................................... Patch Set 1: Code-Review-1 (5 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/1/pcu/GPRS_Components.ttcn File pcu/GPRS_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/1/pcu/GPRS_Components.ttcn@a235 PS1, Line 235: /* 3GPP TS 44.018, table 9.1.8.1, note 2b: Request Reference shall be set to 127 : * when Immediate Assignment is triggered by EGPRS Packet Channel Request. Here : * we assume that 11 bit RA always contains EGPRS Packet Channel Request. */ : if (is_11bit != 0) { ra := 127; } This should have not been removed. That's why the related test cases fail. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/1/pcu/GPRS_Components.ttcn@48 PS1, Line 48: GsmRrMessage Do we really need to store the RR Immediate Assignment in a TBF record? As far as I understand, we parse it and store all parsed parameters here. What if a TBF was assigned on PACCH? There would be no RR Immediate Assignment content to store here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/1/pcu/GPRS_Components.ttcn@49 PS1, Line 49: PacketDlAssign ass, : PacketDlAssignment rlcmac_ass, Please add a couple of comments here, what is the difference between both? If I understand correctly, 'ass' contains parameters from CCCH assignment message and 'rlcmac_ass' contains parameters from PACCH assignment message. It also makes sense to use a union here and properly name its members: 'ccch_ass', 'pacch_ass'. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/1/pcu/GPRS_Components.ttcn@56 PS1, Line 56: GsmRrMessage rr_imm_ass, : PacketUlAssign ass, : PacketUlAssignment rlcmac_ass, Same comments apply here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/1/pcu/GPRS_Components.ttcn@72 PS1, Line 72: UlTbf ul_tbf optional, : DlTbf dl_tbf optional Please add a comment that there can be more than one UL/DL TBF. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib3fee37580f0ea0530a659dec83656799bf57288 Gerrit-Change-Number: 18370 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Tue, 19 May 2020 20:06:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
