Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370 )
Change subject: pcu: Refactor GPRS infrastructure to keep state and simplify tests ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/1/pcu/GPRS_Components.ttcn File pcu/GPRS_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/1/pcu/GPRS_Components.ttcn@a235 PS1, Line 235: /* 3GPP TS 44.018, table 9.1.8.1, note 2b: Request Reference shall be set to 127 : * when Immediate Assignment is triggered by EGPRS Packet Channel Request. Here : * we assume that 11 bit RA always contains EGPRS Packet Channel Request. */ : if (is_11bit != 0) { ra := 127; } > So what's the point then for tests TC_egprs_pkt_chan_req*() crafting ra > values if finally this value […] Feel free to check out the spec. reference mentioned in the comment. TL;DR In case of 11 bit Access Burst, the actual RA is contained in IA Rest Octets (grep 'ext_ra' fiels), while this field is set to 127. So please keep it - it's here for purpose. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib3fee37580f0ea0530a659dec83656799bf57288 Gerrit-Change-Number: 18370 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Wed, 20 May 2020 11:27:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: Vadim Yanitskiy <[email protected]> Gerrit-MessageType: comment
