pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18641 )
Change subject: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/osmocom-bb/+/18641/6/src/target/trx_toolkit/fake_trx.py File src/target/trx_toolkit/fake_trx.py: https://gerrit.osmocom.org/c/osmocom-bb/+/18641/6/src/target/trx_toolkit/fake_trx.py@241 PS6, Line 241: # Apply RSSI based on transmitter: : if not self.fake_rssi_enabled: : msg.rssi = src_trx.tx_power - src_msg.pwr - self.PATH_LOSS_DEFAULT : else: # Apply fake RSSI : msg.rssi = self.rssi > Feel free to move this computation to @property self.rssi (line 156). I'm sorry but I don't understand what do you mean. If you mean somehow encapsulating "src_trx.tx_power - src_msg.pwr - self.PATH_LOSS_DEFAULT" so that it comes when you use self.rssi, I think it doesn't make sense, since one thing is rssi of a message (which requires src_msg and src_trx) and the other is the rssi calculated independently when fake_rssi is in use. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3ee1a32ca22c3272e66b3ca78e4f67d283844c80 Gerrit-Change-Number: 18641 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <vyanits...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 03 Jun 2020 20:03:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vadim Yanitskiy <vyanits...@sysmocom.de> Gerrit-MessageType: comment