laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/18641 )

Change subject: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmocom-bb/+/18641/6/src/target/trx_toolkit/fake_trx.py
File src/target/trx_toolkit/fake_trx.py:

https://gerrit.osmocom.org/c/osmocom-bb/+/18641/6/src/target/trx_toolkit/fake_trx.py@109
PS6, Line 109: 50 # dBm
no problem doing that in a virtual environment, but it's a *very* unrealistic 
value.  It equals a 100W BTS :)  maybe use something closer to reality like 
30-46 dBm.  Keep in mind, dB are logarithmic, so every increase of '3' means a 
doubling in power.



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18641
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I3ee1a32ca22c3272e66b3ca78e4f67d283844c80
Gerrit-Change-Number: 18641
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Comment-Date: Sun, 07 Jun 2020 19:26:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to