fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18641 )
Change subject: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/osmocom-bb/+/18641/6/src/target/trx_toolkit/fake_trx.py File src/target/trx_toolkit/fake_trx.py: https://gerrit.osmocom.org/c/osmocom-bb/+/18641/6/src/target/trx_toolkit/fake_trx.py@293 PS6, Line 293: Use negative threshold to disable fake_rssi if previously enabled: So one would need to send something like 'FAKE_TOA -60 -1' in order to make fake_trx.py stop using previously indicated 'fake' RSSI value, right? And '-60' in this example is a dummy value that simply should be there. Most of the commands on TRXC are kind of self-explaining, so you don't have to dig into the source code to understand their purpose. It would be nice to make this command self-explaining too. How about 'NOFAKE_RSSI'? or 'FAKE_RSSI OFF'? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3ee1a32ca22c3272e66b3ca78e4f67d283844c80 Gerrit-Change-Number: 18641 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Sun, 07 Jun 2020 19:50:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
