dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/19670 )

Change subject: vty: add attributes to VTY commands indicating when they apply
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/19670/6/src/osmo-bsc/bsc_vty.c
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/19670/6/src/osmo-bsc/bsc_vty.c@2050
PS6, Line 2050:               cfg_net_neci_cmd,
These flags are to be interepreted as or connected? What about also setting 
"BSC_VTY_ATTR_RESTART_FULL" because that also will cause the change to apply? I 
know that is obvious, but I just wonder about completeness...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19670
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I3bf9223295fc4a2fcb4046a1f29f792ff6a41d51
Gerrit-Change-Number: 19670
Gerrit-PatchSet: 6
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Assignee: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 22 Sep 2020 09:32:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to