laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19670 )
Change subject: vty: add attributes to VTY commands indicating when they apply ...................................................................... Patch Set 8: (2 comments) We are missing an update to the user manual, too. https://gerrit.osmocom.org/c/osmo-bsc/+/19670/8/src/osmo-bsc/abis_om2000_vty.c File src/osmo-bsc/abis_om2000_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/19670/8/src/osmo-bsc/abis_om2000_vty.c@91 PS8, Line 91: "BTS Number\n" "Associated SO Instance\n" "Instance Number\n", pretty much all of the commands here are not configuration commands. they are installed in the OM2K_NODE hierarchy, which is below the "ENABLE" node. Those are like "show subscriber" or "drop BTS oml link" which are always imperative, immediate commands as they are outside the "confiugure terminal" node. I think we only should add attributes to commands that are below the "configure terminal" node. https://gerrit.osmocom.org/c/osmo-bsc/+/19670/8/src/osmo-bsc/abis_om2000_vty.c@278 PS8, Line 278: CMD_ATTR_IMMEDIATE I think all the commands from top to here are not part of the "configure" -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19670 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3bf9223295fc4a2fcb4046a1f29f792ff6a41d51 Gerrit-Change-Number: 19670 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <[email protected]> Gerrit-Assignee: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Wed, 30 Sep 2020 07:51:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
