fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19670 )
Change subject: vty: add attributes to VTY commands indicating when they apply ...................................................................... Patch Set 8: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/19670/8/src/osmo-bsc/osmo_bsc_main.c File src/osmo-bsc/osmo_bsc_main.c: https://gerrit.osmocom.org/c/osmo-bsc/+/19670/8/src/osmo-bsc/osmo_bsc_main.c@653 PS8, Line 653: usr_attr_letters One more thing: as was discussed in the mailing list, let's use lower case letters for application specific flags. Upper case should be used in libosmo-*, so we have a clear distinction. https://gerrit.osmocom.org/c/osmo-bsc/+/19670/8/src/osmo-bsc/osmo_bsc_main.c@656 PS8, Line 656: N I think there can also be 'NEW_BTS', 'NEW_TRX', and so on... Let's rather use 'l' or 'c' (first/second letter of lchan) here? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19670 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3bf9223295fc4a2fcb4046a1f29f792ff6a41d51 Gerrit-Change-Number: 19670 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <[email protected]> Gerrit-Assignee: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Fri, 02 Oct 2020 08:45:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
