In reply to Andreas Beck <[EMAIL PROTECTED]>
>
>> > http://sourceforge.net/projects/psv
>> to view PS. I'll dowload that ASAP ... 
>
>O.K. - did that. A few comments:
>
>1. ggi_visual_t *visual  is wrong. It should be ggi_visual_t visual .
>   I am getting type-conversion warnings. ggi_visual_t is already a 
>   pointer - no need to double it. This is non-fatal, though, except if
>   there was a sick architecture, where a pointer to a pointer to a ggi
>   visual is stored in another way than just a pointer to a ggi visual.

strange, i never got any warnings. anyway, changed it, its correct for
version 1.3.

>2. What about color ?
>   Not that it is necessary, but I get really strange atrifacts in colored
>   areas. Kind of like when you got wrong colors in a palettized mode ...
>   Might be a problem of ghostscript, though.

that's probably a ghostscript problem. tiger.ps looks quite nice in
grayscale in my video, though. i agree that colors are nice, so
anybody's invited to implement it.

>3. Zooming ? It would be interesting, if you could request to re-render at
>   a different resolution. Some documents use small fonts, which will be 
>   unreadable without zooming and panning.

with anti-aliasing zooming gets quite unecessary, but i make a point
of implementing it for version 1.3, whenever it gets released. zooming
isn't complicated to implement anyway.

>4. Additional keybindings to the cursor and paging keys. Should be easy to
>   add (you will need to use ggiEventRead instead of Getc, but it is pretty
>   straightforward and demonstrated in e.g. the cube3d demo. Don't bother
>   about the EventPoll and the Mouse and escaping stuff - just look at
>   Row 871-873 (ggiEventRead(vis,&event,emAll);) and rows 881-965. 
>   Should be easy to add. "hjkl" is not quite intuitive.

i agree, but its much more ergonomic, and it's vi-like, so it's not
from another world (i'm a vim user, so you can guess). but i guess
i'll have to bind cursor and page keys in version 1.3...

>5. Requiring document structure comments is a pretty strong prerequisite.
>   Even all the PS demos will fail. Would it be possible to just do the
>   thing gv does and disallow out-of-sequence-viewing in that case ?

that would complicate the code a lot, i think. at this time i pass a
page at a time for ghostscript to render it. without dsc comments
there are no effective indications of where pages start and end. --
just as an aside, not *all* the ps demos fail: tiger.ps works.

--
Cesar Augusto Rorato Crusius    __o      __o      __o      __o      __o    
Stanford University           _`\<,    _`\<,    _`\<,    _`\<,    _`\<,    
e-mail:[EMAIL PROTECTED]    (_)/(_)  (_)/(_)  (_)/(_)  (_)/(_)  (_)/(_)   
www.stanford.edu/~crusius
                                       o      _     _         _
   __o      __o      __o      __o     /\_   _ \\o  (_)\__/o  (_)
 _`\<,    _`\<,    _`\<,    _`\<,    _>(_) (_)/<_    \_| \   _|/' \/
(_)/(_)  (_)/(_)  (_)/(_)  (_)/(_)  (_)        (_)   (_)    (_)'  _\o_

He who sacrifices functionality for ease of use
Loses both and deserves neither

Reply via email to