On Sat, 14 Dec 2002, Andreas Beck wrote: > > My guess is, that the dirty region tracking code gets messed up by > > the Hline. > > Confirmed the GGI_X_CLEAN-Macro contains a bug (I think, it is pretty > had to understand) Diff attached, please validate before I commit. > > Rationale for the changes: > > Old code was: >
[...] > > I spent quite a while thinking this code through, and suppose I got it > right. I am not quite sure about the last two ifs in each chain. I think one > could use greater/less-or-equal in the comparisions as well, thus correctly > handling regions that just touch the borders. > > > I have tested these changes with my application, and it fixes the problems > I reported. > > Could you please go over the code and my comments and have a look, if the > fix is right? That stuff is pretty complex to think into, so I am not > absolutely positive I didn't mis anything. > > If a few people confirm my thought, I will commit. I have tested your patch under Linux/i386 and Solaris 8/Sparc32. Tomorrow evening, I can test it under MacOS X/PPC32, too. And your patch works fine for me, so far... Good work! BTW: Eric added a ggiGetCharSize manual page and documented the stuff you mentioned. CU, Christoph Egger E-Mail: [EMAIL PROTECTED]
