On Jan 13, 2012, at 2:46 AM, Dave Webb wrote: > I already did some patching for these syntax changes in my github files. > https://github.com/davewebb8211/ghdl/ > in the 'nick' branch. > https://github.com/davewebb8211/ghdl/commit/2646d165b2b5c01161b0e498c8b33f9ebcd54248
Before the last little diff -u for the GTY (()) and identifier reversals I had the differences from a mainline copy of ghdl -r143 and the one I thought was your current one (master). It had an order change on line 32 of ortho-lang.c but not the other four beginning around line 760. Your ghdl.patch contained the additional changes. I originally grabbed your git from .tar.gz of the master branch. Those additional changes aren't in there. (davewebb8211-ghdl-2646d16.tar.gz) I saw the changes in the nick branch, and the bit in grt-values.adb about LRM-2008 16.1 is dangerous. First, IEEE 1076-1993 should be considered normative for ghdl, and the correct section is 15.3 (2008) or 13.2 (1987, 1993): At least one separator is required between an identifier or an abstract literal and an adjacent identifier or abstract literal. Someone working on a tool that can distinguish features between LRM revisions should really be a bit more specific, you'll have us VHDL lawyers howling. Notice Nick got the "at least one" part right. The objection is to putting inaccurate comments in the code base. The bug fix appears valid.
dist.sh.diff
Description: Binary data
Make-lang.in.diff
Description: Binary data
Makefile.diff
Description: Binary data
ortho-lang.c.diff
Description: Binary data
_______________________________________________ Ghdl-discuss mailing list [email protected] https://mail.gna.org/listinfo/ghdl-discuss
